Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L Legal
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Security and Compliance
  • Legal
  • Merge requests
  • !90

fix the pre-configuration file loading to fail close on the request level.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mingyang Zhu requested to merge fix-fail-open-bug into master Jan 05, 2021
  • Overview 1
  • Commits 1
  • Pipelines 3
  • Changes 1

Related Issue: #3 (closed)

Legal service is now failing open to the "partition country of origin" file loading failure. If it is failed to load the configuration file, the request returns successfully by considering there is no content in the configuration

Failing open isn't a bad thing from a partition point of view. e.g. don't fail the whole service because one partition doesn't load. Maybe its ok that the single partition isn't available, the concern if it fails open for a partition is existing valid legal tags could be made non-compliant and then soft delete data related to it. so the fix should only fail the partition which can't load the configration file but not the whole service

Edited Jan 05, 2021 by Mingyang Zhu
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-fail-open-bug