Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • E entitlements-azure
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Security and Compliance
  • entitlements-azure
  • Merge requests
  • !25

Fix for enabling root level SP

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed harshit aggarwal requested to merge haaggarw/RootAccessQuickFix into master Sep 26, 2020
  • Overview 10
  • Commits 9
  • Pipelines 14
  • Changes 8

This PR contains fix for enabling support for Root Level SP [ Note: This is only an interim solution ]

We are adding a check in getGroups method that if a call is made from a certain SP [aka Root SP] we will return all the groups in the tenant by querying TenantInfo collection

For the check we are comparing object ID's [OID] of the service principals. The OID of the Root SP will be read from the key vault.

Appropriate infra changes done through following Pull Requests PR1 , PR2 and PR3, though it might take some time for changes to get deployed

Edited Oct 13, 2020 by harshit aggarwal
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: haaggarw/RootAccessQuickFix