Skip to content
Snippets Groups Projects

chore: [For MSFT Team Review]: Refactor getDatasetsQuery to remove code duplication

[Internal PR, target branch is not master]

Updates description?

The code of the getDatasetsQuery was duplicated between the abstract Journal class and its Cosmos DB implementation, which added some additional behaviour.

This duplication creates technical debt and complicates the implementation of additional behaviour such as #117 (closed).

Refactored to remove duplication, adding an empty method customizeDatasetsQuery in the abstract class which is overridden in the Cosmos DB implementation.

Other storage providers have the option to implement the STARTSWITH operator to support recursive=true.

Edited by Alexandre Gattiker

Merge request reports

Merge request pipeline #219329 failed

Merge request pipeline failed for 99601ed0

Merged by Alexandre GattikerAlexandre Gattiker 1 year ago (Oct 19, 2023 12:17pm UTC)

Loading

Pipeline #219330 failed

Pipeline failed for a2730897 on msft/feat/filtering-support

Test coverage 53.80% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading