Skip to content

Fix issues reported by Cppcheck tools

Fabien Bosquet requested to merge bosquet/SAST_cppecheck_fixes into main

Type of change

  • Bug Fix
  • Feature

Does this introduce a change in the core logic?

  • [No]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Updates description?

This merge request is to fix the 11 issue reported by Cppcheck.

Note that CppCheck SAST is run on all pipeline and the issues are reported in the Code Quality tab

https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/reservoir/open-etp-server/-/pipelines/199781/codequality_report

  • Major - Member variable 'ConnectionMetaData::correlationId_' is not initialized in the constructor. (CWE-398) in src/lib/oes/postgresql/DbConnectionPool.cpp:42
  • Major - The struct 'VoidRPC' defines member variable with name 'rc_' also defined in its parent struct 'BaseRPC'. (CWE-398) in src/lib/oes/testing/eml/ServerTesting.hpp:138
  • Minor - The statement 'if (handshake_.authorization_!=token) handshake_.authorization_=token' is logically equivalent to 'handshake_.authorization_=token'. (CWE-398) in src/lib/oes/eml/etp12/Server.cpp:2200
  • Minor - Condition '!user_' is always true (CWE-571) in src/lib/oes/eml/etp12/Server.cpp:1960
  • Minor - Unused variable: input_epc_file (CWE-563) in src/tests/eml/openkv/AdminDBTests.cpp:116
  • Minor - Variable 'dbConnection1' is assigned a value that is never used. (CWE-563) in src/tests/postgresql/DbConnectionPoolTests.cpp:110
  • Minor - Variable 'dbConnection2' is assigned a value that is never used. (CWE-563) in src/tests/postgresql/DbConnectionPoolTests.cpp:111
  • Minor - Variable 'dbConnection1' is assigned a value that is never used. (CWE-563) in src/tests/postgresql/DbConnectionPoolTests.cpp:124
  • Minor - Variable 'transaction' is assigned a value that is never used. (CWE-563) in src/tests/postgresql/TransactionTests.cpp:93
  • Minor - Variable 'space1Uri' is assigned a value that is never used. (CWE-563) in src/tests/eml/openkv/TransProtoTests.cpp:178
  • Minor - Variable 'space2Uri' is assigned a value that is never used. (CWE-563) in src/tests/eml/openkv/TransProtoTests.cpp:179
Edited by Fabien Bosquet

Merge request reports