Skip to content

Adding custom info in MDC context for `PUT record` request

Vibhuti Sharma [Microsoft] requested to merge users/Vibhuti/add-baseline-metric-info into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [NA] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

High level design: We want to extrapolate the latency of entity creation in storage service - average time taken to create one record. We can do this by querying the requests table in application insights, as it contains the duration for every PUT record call. However it does not contain info about number of records created/updated. This MR adds the same.

Issue: NA

Change details: Adding relevant key-value pair to MDC context in CloudStorageImpl.java

Test coverage:

NA

Does this introduce a breaking change?

NO

Pending items

NO

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Merge request reports