Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • S Storage
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 50
    • Issues 50
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Storage
  • Merge requests
  • !105

Gcp update os core common / fix pubsub publisher (GONRG-1211/GONRG-1299)

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rustam Lotsmanenko (EPAM) requested to merge gcp-update-os-core-common into master Dec 07, 2020
  • Overview 4
  • Commits 38
  • Pipelines 8
  • Changes 3

Description:

Two changes:

  1. Update core-common with url normalization fix;
  2. Fix pubsub publisher, creating new publisher instance for each publish request leading to java.lang.RuntimeException: ManagedChannel allocation site io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue: *~*~*~ Channel ManagedChannelImpl{logId=4613, target=pubsub.googleapis.com:443} was not shutdown properly!!!

How to test:

  1. Url normalization fix: Service was configured with malformed entitlements url, and keep working properly.
  2. Publisher fix: Error RuntimeException: ManagedChannel allocation site Count 10,920 Last seen 3 days ago Service keep working properly , and not throwing Runtime exception related to misbehaving with connection.

Changes include:

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Changes in:

  • GCP
  • Azure
  • AWS
  • IBM

Dev Checklist:

  • Added Unit Tests, wherever applicable.
  • Updated the Readme, if applicable.
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments:

depends on osdu/platform/system/lib/core/os-core-common!38 (merged)

Edited Dec 07, 2020 by Rustam Lotsmanenko (EPAM)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gcp-update-os-core-common