Azure istio auth file rename
All Submissions:
- [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
- [YES/NO] I have updated the documentation accordingly.
- [YES/NO/NA] I have added tests to cover my changes.
- [YES/NO/NA] All new and existing tests passed.
- [YES/NO/NA] My code follows the code style of this project.
- [YES/NO/NA] I ran lint checks locally prior to submission.
What is the issue or story related to the change?
Following the convention I noticed for auth files in Legal service.
High level design:
Issue:
Change details:
Test coverage:
Does this introduce a breaking change?
- [YES/NO]
Pending items
Reviewer request
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>
Other information
Edited by Komal Makkar
Merge request reports
Activity
assigned to @harshit283, @kibattul, and @kiveerap
@polavishnu @kibattul @komakkar I see that storage and legal service are using different names for this file
Can we follow a common naming pattern here?
added 5 commits
-
d194c8d6...927d265d - 4 commits from branch
master
- 2c1ff7de - Merge branch 'master' of...
-
d194c8d6...927d265d - 4 commits from branch
Merging this MR though aws tests failing as this MR doesn't touch any of the other CSP providers code. Also the code is nothing to do with any of the GLab related things.
CC: @dkodeih
mentioned in commit 48e3bd55
mentioned in commit 9b6eaa9c
added Azure label
changed milestone to %M1 - Release 0.1
Please register or sign in to reply