Skip to content

Fix that URL encodes the hmac for subscription

Derek Hudson requested to merge aws-fix-for-hmac-url-encoding into master

Type of change

  • Bug Fix
  • Feature

Link to issue

Does this introduce a change in the core logic?

  • [YES]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • Google Cloud
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

The hmac signature is not URL encoded, which can cause issues with some strict URL parsers.

The only time = is allowed in a query string is when delimiting the key-value pair for that query parameter.

What is the new/expected behavior?

The hmac signature is now properly URL encoded on the subscription verification request.

Have you added/updated Unit Tests and Integration Tests?

Added a Unit Test to verify that the hmac signature is properly encoded.

Any other useful information

Merge request reports