Skip to content

Conditional Header for Non Request Scopes

Nikhil Singh[MicroSoft] requested to merge users/nikhil/ConditionalHeader into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [NA] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

CredentialHeaderProvider is marked as primary Bean. This bean is applicable for request scope mechanism. If any of the CSP's wish to override this bean to have their own implementation for non request scope then it would not be possible as this is marked as Primary.

What are the change details?

We want the CredentialHeaderProvider core bean for 2 cases:

1-All CSP's except azure (property "requestScope.enabled" wont be there ,match if missing = true)

2-Azure Event grid -(property "requestScope.enabled" would be there with value = true)

For the case of Service bus we want our own Thread Scope Headers and core bean is getting ignored (property "requestScope.enabled" would be there with value = false)

If any CSP wish to override this bean, they can have the above mentioned property as false.

Test coverage:

NA

Does this introduce a breaking change?

  • [NO]

Pending items

Edited by Nikhil Singh[MicroSoft]

Merge request reports