Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • N Notification
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe Software
  • Platform
  • System
  • Notification
  • Merge requests
  • !87

Notification Service Refactoring

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nikhil Singh[MicroSoft] requested to merge users/nikhil/NotifServiceRedesign into master Jun 11, 2021
  • Overview 56
  • Commits 16
  • Pipelines 34
  • Changes 13

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [NO] I have updated the documentation accordingly.
  • [NO] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


The MR contains changes to redesign notification service in order to make the code extensible and support multiple message brokers in future.

High level design: In the PubSubEndpoint Controller, handlers have been added in order to call the functions which fetches out the subscription and notify the subscriber endpoint.

Issue: #25 (closed)

Test coverage:


Does this introduce a breaking change?


  • [NO]

Pending items


Implementation of POJO to contain request body details

Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Harshit/Komal/Vishnu> -- Backward Compatibility: <Harshit/Komal/Vishnu> -- Feature Logic: <Harshit/Komal/Vishnu>

Other information


Edited Jul 26, 2021 by Nikhil Singh[MicroSoft]
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: users/nikhil/NotifServiceRedesign