Skip to content

Added in a URL encoding for the Base64 output of the HMAC authentication URL

Derek Hudson requested to merge aws-fix-url-encoder-on-post-push-endpoint into master

Type of change

  • Bug Fix
  • Feature

Link to issue

Does this introduce a change in the core logic?

  • [YES]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • Google Cloud
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

HMAC Query String values can include the = character, which can cause the push endpoint to fail.

What is the new/expected behavior?

HMAC Query String values that would otherwise include the = character have that character replaced with %3d or %3D.

Have you added/updated Unit Tests and Integration Tests?

Yes. Added a test to verify that this is the case.

Any other useful information

Merge request reports