Skip to content
Snippets Groups Projects

Using http endpoint for register.

Merged Komal Makkar requested to merge users/komakkar/adding_http_register_endpoint into master

All Submissions:


  • [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? Yes
  • [YES/NO] I have updated the documentation accordingly. NA
  • [YES/NO/NA] I have added tests to cover my changes. NA
  • [YES/NO/NA] All new and existing tests passed. Yes in IDCMVP
  • [YES/NO/NA] My code follows the code style of this project. Yes
  • [YES/NO/NA] I ran lint checks locally prior to submission. NA

What is the issue or story related to the change?


High level design:

Issue:

Change details:

  1. Inter-service communication happens via Http endpoints. As register service has enabled that endpoint, using the same.

Test coverage:


Does this introduce a breaking change?


  • [YES/NO]

Pending items


Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information


Merge request reports

Merge request pipeline #17441 passed with warnings

Pipeline: Notification

#17491

    Merge request pipeline passed with warnings for 7ab2e66e

    Deployed to A‎WS‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago
    Approval is optional

    Merged by Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft] 4 years ago (Nov 30, 2020 8:35am UTC)

    Merge details

    • Changes merged into with 0c66d8c8.
    • Deleted the source branch.

    Pipeline #17686 failed

    Pipeline failed for 0c66d8c8 on master

    Deployed to I‎BM‎ 4 years ago
    Deployed to A‎WS‎ 4 years ago

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply
    Loading