Skip to content
Snippets Groups Projects

Core Change: Original Exception is getting logged.

Merged Core Change: Original Exception is getting logged.
users/komakkar/logOriginalException into master
1 unresolved thread
Merged Komal Makkar requested to merge users/komakkar/logOriginalException into master
1 unresolved thread

All Submissions:

  • [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES/NO] I have updated the documentation accordingly.
  • [YES/NO/NA] I have added tests to cover my changes.
  • [YES/NO/NA] All new and existing tests passed.
  • [YES/NO/NA] My code follows the code style of this project.
  • [YES/NO/NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

High level design:

Issue: #18 (closed)

Change details:

The change is making sure the original exception message is getting logged. The cause of the exception will always be null as we are not setting it to be anything. The originalException has to be evaluated in this case.

Test coverage:

Does this introduce a breaking change?

  • [YES/NO] No

Pending items

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Edited by Komal Makkar

Merge request reports

Merge request pipeline #21638 failed

Stage: .pre
Stage: review
Pipeline: Notification

#21719

    Merge request pipeline failed for 71bb69fc

    Deployed to A‎WS‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago
    Approval is optional

    Merged by Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft] 4 years ago (Jan 18, 2021 6:06am UTC)

    Merge details

    Pipeline #21865 passed with warnings

    Stage: .pre
    Stage: build
    Stage: containerize
    Stage: scan
    Stage: deploy
    Stage: integration
    Stage: attribution

    Pipeline passed with warnings for 2cd2d058 on master

    Deployed to I‎BM‎ 4 years ago
    Deployed to A‎WS‎ 4 years ago

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply