Skip to content

Improving logs to deal with negative case scenarios

Harshika Dhoot requested to merge logsnotif into azure/m16-master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • [YES/NO] NO

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • Google Cloud
  • IBM

Does this introduce a breaking change?

  • [YES/NO] NO

What is the current behavior?

Logs including correlation id, http method, url, request and response body weren't present for debugging any issue that arises

What is the new/expected behavior?

To receive information like correlation id, http method, url, request and response body for better debugging and getting ahold of any issue that arises and empowering us to reach to the root cause

Have you added/updated Unit Tests and Integration Tests? Added logs in Integration tests

Any other useful information

Compatibility with ADME INSTANCE: all test cases in notification ran:notificationsdme

test case scenarios

  1. Green test case: registergreen

  2. unknown host exception: here we are getting url, correlation id, data partition id and http method for this exception notif1

  3. socket timeout exception: here we are getting the request send information and stack trace for socket timeout the retry after the socket timeout,registersocket

  4. subscription request: regissubs

  5. subscription response:regissubsres

Edited by Harshika Dhoot

Merge request reports