Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • N Notification
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Notification
  • Merge requests
  • !257

Refactor AuthorizationFilter::hasAnyPermission to avoid always returning true

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Xiangliang Meng requested to merge DavidMeng-master-patch-92375 into master Sep 01, 2022
  • Overview 10
  • Commits 1
  • Pipelines 10
  • Changes 1

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)
It is a problem found by sonarQube that the method AuthorizationFilter::hasAnyPermission always return true from all its branches

Does this introduce a change in the core logic?

  • [YES]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

The method AuthorizationFilter::hasAnyPermission always return true from all its branches

What is the new/expected behavior?

The method AuthorizationFilter::hasAnyPermission might return false in some situation.

Have you added/updated Unit Tests and Integration Tests?

No.

Any other useful information

Edited Sep 08, 2022 by Okoun-Ola Fabien Houeto
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: DavidMeng-master-patch-92375