Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O OS Core Common
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Lib
  • core
  • OS Core Common
  • Merge requests
  • !90

Implemented HttpClientHandler to an interface

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Muskan Srivastava requested to merge muskans-core-http into master May 25, 2021
  • Overview 6
  • Commits 1
  • Pipelines 4
  • Changes 3

This MR implements HttpClientHandler to an interface- IHttpClientHandler. Also, changes RETRY_COUNT and REQUEST_CONFIG from being private final to protected static.

We follow the pattern of implementing to the interface across the entire project, hence this MR wants to bring HttpClientHandler to the same line. Moreover, doing so will make the class extensible. Making REQUEST_CONFIG and RETRY_COUNT protected static will allow the extended classes to configure these parameters.

Impact :
This will enable us to: -

  1. Have same coding pattern across project.
  2. Extend HttpClientHandler.
  3. Configure REQUEST_CONFIG and RETRY_COUNT in child classes.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: muskans-core-http