Closed requested to merge users/nikhil/ScopeChangesForNonRequestScopes into master
- [YES] I have added an explanation of what changes in this merge do and why we should include it?
- [NO] Does the MR contain pipeline/ helm chart related changes?
- [NO] I have updated the documentation accordingly.
- [NO] I have added tests to cover my changes.
- [NA] All new and existing tests passed.
- [YES] My code follows the code style of this project.
- [NA] I ran lint checks locally prior to submission.
What is the issue or story related to the change?
The MR contains change to remove the Request Scope from SignatureService as it is used by Non Request scope as well.
Providing an example, this comes under the Service Bus flow(Non Request Scope) as well when it uses the HMAC Auth to form signed jwt to send notification pulled from service bus to the actual endpoint. This flow is non request scoped and bean creation was failing for it.
Does this introduce a breaking change?
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR -- Coding design: <Harshit/Komal/Vishnu> -- Backward Compatibility: <Harshit/Komal/Vishnu> -- Feature Logic: <Harshit/Komal/Vishnu>