Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O OS Core Lib Azure
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Lib
  • cloud
  • azure
  • OS Core Lib Azure
  • Merge requests
  • !80

Draft: Fix partition service client

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Rostyslav Matushkin (SLB) requested to merge fix_partition_service_client into master Mar 02, 2021
  • Overview 0
  • Commits 2
  • Pipelines 2
  • Changes 3

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NA] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


Existing Behaviour: Each invocation of the method org.opengroup.osdu.azure.partition.PartitionServiceClient:getServiceClient overwrites the existing Authorization header in DpsHeaders. The token is overriden by result from the method org.opengroup.osdu.azure.util.AzureServicePrincipleTokenService:getAuthorizationToken. This is an erroneous behavior that overwrites the token of the client accessing the service.

Updated Behaviour: Each invocation of the method org.opengroup.osdu.azure.partition.PartitionServiceClient:getServiceClient will populate the Authorization header by result from the method org.opengroup.osdu.azure.util.AzureServicePrincipleTokenService:getAuthorizationToken in DpsHeaders only in a case when the header is absent.

Test coverage:


Screenshot_2021-03-02_at_14.23.11

Does this introduce a breaking change?


  • [NO]

Pending items


Entitlements service requires this change to fix authorization logic.

Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>
Edited Mar 02, 2021 by Rostyslav Matushkin (SLB)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_partition_service_client