Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O OS Core Lib Azure
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Lib
  • cloud
  • azure
  • OS Core Lib Azure
  • Merge requests
  • !45

Added getSasToken method in `BlobStore.java`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aalekh Jain requested to merge getSasToken into master Nov 12, 2020
  • Overview 7
  • Commits 2
  • Pipelines 4
  • Changes 1

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] I have updated the documentation accordingly.
  • [NO] I have added tests to cover my changes. (will be added)
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NO] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

Please refer to the linked issue: #2 (closed)

Test coverage:

Tests to be added

Does this introduce a breaking change?

  • [NO]

Pending items

  • Adding UTs for getSasToken method.

Reviewer request

Other information

This method can be used across various services wherever there is a need to interact with the blobs (creating/modifying/reading the blobs) present in the storage container for either

In order to generate sas tokens, we need to provide StorageSharedKeyCredential. This must be done by obtaining the BlobServiceClient by using credentials storageSharedKeyCredential. Refer to this for a sample implementation (done for ingestion service).

Edited Nov 12, 2020 by Aalekh Jain
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: getSasToken