Skip to content

Draft: Cryptography Retry Configuration

Ronak Sakhuja requested to merge rosakhuj/crypto into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

Cryptographyoffers option for configuring various attributes for retry policy. For any service who wish not to use the default values, and want to provide custom values for the mentioned attributes, they will be able to after this change.

High level design: image Issue:

Change details: Variables that can be added to are: azure.cryptography.retryStrategyValue azure.cryptography.FixedDelayConfiguration.maxRetries azure.cryptography.FixedDelayConfiguration.delay azure.cryptography.ExponentialBackoffConfiguration.maxRetrues azure.cryptography.ExponentialBackoffConfiguration.baseDelayInMillis azure.cryptography.ExponentialBackoffConfiguration.maxDelayInSeconds azure.cryptography.retryAfterHeader azure.cryptography.retryAfterTimeUnit

Test coverage:

All changes are covered.

Does this introduce a breaking change?

  • NO

Pending items

Documentation will come in a separate MR.

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Edited by Ronak Sakhuja

Merge request reports