Skip to content

Removing logging dependencies from parent pom

Vibhuti Sharma [Microsoft] requested to merge users/Vibhuti/removing-parent-pom-dependencies into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

High level design: Removing dependencies on slf4j-jdk14, slf4j-api, log4j-to-slf4j from parent pom and adding them to the child poms instead.

Issue: There are 3 logging related dependencies in the parent pom which clash with logging dependencies in child pom in indexer-queue-azure-enqueue module. Since exclusions cannot be added when inheriting from parent pom, we can remove these dependencies from parent pom and add them to the respective child poms which need them.

Change details: NA

Test coverage:

NA

Does this introduce a breaking change?

  • NO

Pending items

NA

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Merge request reports