Skip to content

Draft: Added CORS support in Azure

Krishna Nikhil Vedurumudi requested to merge cors into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [YES] I have updated the documentation accordingly.
  • [YES/NO/NA] I have added tests to cover my changes.
  • [YES/NO/NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

High level design:

Issue:

Change details:

CORS configurations can now be taken from Application Properties. These configurations will allow the Signed URLs for Upload and Download work in any domain that the client will whitelist.

Test coverage:

Does this introduce a breaking change?

  • [NO] The change is introduced by a flag. So, the clients will get the reflected changes only if they opt to.

Pending items

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Edited by Krishna Nikhil Vedurumudi

Merge request reports