Skip to content

Azure: fixing cosmos and storage access

Jason requested to merge azure-fixing-cosmos-and-storage-access into master

All Submissions:

  • [YES] Have you followed our code review guidelines?
  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NO] I ran lint checks locally prior to submission.

What is the current behavior?

  • Cosmos and storage info are expected as environment variables. Helm chart expects them to be available as secrets in kv-secrets.yaml, and they are going to be removed from there soon.
  • The test first_getLocation_then_shouldReturnFileList_sameFileId fails occasionally because Cosmos does not have strong consistency and the test is querying Cosmos directly after writing to it.

What is the new behavior?

  • Cosmos and storage info is retrieved directly from keyvault.
  • first_getLocation_then_shouldReturnFileList_sameFileId should pass because there is now a much wider window allowed for the write to have been registered with cosmos in order for the test to pass.

Does this introduce a breaking change?

  • [NO]
Edited by Jason

Merge request reports