Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Wellbore Domain Services Wellbore Domain Services
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe Software
  • Platform
  • Domain Data Mgmt Services
  • Wellbore
  • Wellbore Domain ServicesWellbore Domain Services
  • Merge requests
  • !175

remove unnecessary parametrize cases in integration tests "multiple_sessions_in_parallel"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Yannick requested to merge remove_duplicated_test into master Jul 13, 2021
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

Motivation: These 2 integration tests are related to session management. It checks everything work as expected when multiple sessions are alive in parallel on same record. These tests were parametrize to check over different data format (JSON/parquet) and entity types (WellLog, Trajectory, Log) and then leads to 6 distinct combinations data format/entity type each (so 12 tests in total). Testing all these combination doesn't provide any plus value since it only on session management really matters. Moreover there are dedicated tests to check on all entity types and format.

Since these tests are quite long to execute (between 30s and 20s on dev env), it adds 5 minutes to complete the full integration test set without providing value.

The change here is to only keep one occurrence of each saving 4-5 minutes on pipeline per environment.

Edited Jul 13, 2021 by Yannick
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove_duplicated_test