Skip to content

feat: code enhanced and pre-hook added

Diego Molteni requested to merge slb/dm3/code-review-2 into master

Type of change

  • Bug Fix
  • Feature
  • Pipeline
  • Test
  • Documentation
  • Enhancement

Does this introduce a change in the core logic?

  • No
  • Yes

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Anthos
  • Azure
  • GCP
  • IBM

Does this follow conventional commits spec?

  • No
  • Yes

Have you set the target Milestone?

  • No
  • Yes

Have you set the no-detached-pipeline label?

  • No
  • Yes

Updates description?

  • added code linter
  • added code style
  • added code speller
  • added markdown linter
  • added git pre-hook
  • fixed spell and linting issue in code
  • fixed the cli generator
  • added main README
-------------------------------------------------------
1 - spelling errors check
-------------------------------------------------------

> sdms@4.0.0 spell
> cspell --no-progress .

CSpell: Files checked: 107, Issues found: 0 in 0 files

-------------------------------------------------------
2 - markdown linting
-------------------------------------------------------

> sdms@4.0.0 markdown-lint
> markdownlint-cli2 **/*.md #node_modules

markdownlint-cli2 v0.9.2 (markdownlint v0.30.0)
Finding: **/*.md !node_modules
Linting: 3 file(s)
Summary: 0 error(s)

-------------------------------------------------------
3 - code linting
-------------------------------------------------------

> sdms@4.0.0 lint
> eslint --ignore-path .eslintignore --ext .js,.ts .

-------------------------------------------------------
4 - code formatting
-------------------------------------------------------

> sdms@4.0.0 prettier
> prettier -c src/**/*.ts

Checking formatting...
All matched files use Prettier code style!

-------------------------------------------------------
5 - validate commit message
-------------------------------------------------------

commit message ok

-------------------------------------------------------
Edited by Diego Molteni

Merge request reports

Loading