Skip to content

fix: SDMS - tests don't need "done" callback

Konstantin Gukov requested to merge msft/fix/retire-done-callback into master

Type of change

  • Bug Fix
  • Feature
  • Pipeline
  • Test
  • Documentation

Does this introduce a change in the core logic?

  • No
  • Yes

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Anthos
  • Azure
  • GCP
  • IBM

Does this follow conventional commits spec?

  • No
  • Yes

Have you set the target Milestone?

  • No
  • Yes

Have you set the no-detached-pipeline label?

  • No
  • Yes

Updates description?

Using the "done" callback in the tests is an old feature.

Now it is unnecessary, and when used incorrectly, even leads to the failing tests that display as passing ( see !846 (merged) )

More info about mocha async tests: https://masteringjs.io/tutorials/mocha/async

This change removes the done() callbacks from the tests.

Merge request reports

Loading