Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • S seismic-dms-cpp-lib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe Software
  • Platform
  • Domain Data Mgmt Services
  • Seismic
  • Seismic DMS Suite
  • seismic-dms-cpp-lib
  • Merge requests
  • !71

fix: issue with garbage data in the logs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Paal Kvamme requested to merge slb/kvamme62/garbage-data-was-returned into master Jul 19, 2021
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

Fix a bug where too much data was being returned. Allocated size instead of current size.

This might also have fixed a bug in GcsAccessorImpl::downloadObject().

When verifying the fix, do search for where get_response (the overload with two arguments) is called from and watch out for unintended consequences. Also make sure _response_buffer_written is always up to date.

The bugfix itself was rather banal once the problem was located. It may have uncovered other problems though. I will update the bug report.

Edited Jul 21, 2021 by Sacha Brants
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: slb/kvamme62/garbage-data-was-returned