Skip to content

fix: inconsistent dll linkage (Windows/VS)

Pavel Kisliak requested to merge epam/fix_inconsistent_dll_linkage into master

Type of change

  • Bug Fix
  • Feature
  • Pipeline
  • Test

Does this introduce a change in the core logic?

  • No
  • Yes

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this follow conventional commits spec?

  • No
  • Yes

Have you set the target Milestone?

  • No
  • Yes

Have you set the no-detached-pipeline label?

  • No
  • Yes

Updates description?

This MR fixes build warnings and linking errors on Windows platform when unit tests are enabled (where uses static library).

  • Move definition BUILDING_DLL from source files to CMake
  • Disable export DLL interfaces for static library version
  • Fix warning "Command line warning D9025: overriding '/W3' with '/W4'" (reproducible in the CMake single configuration)

Part of issue: #18

Edited by Pavel Kisliak

Merge request reports