Skip to content
Snippets Groups Projects

Do not call SetErrorForJob before the job is done

Merged Do not call SetErrorForJob before the job is done
feature/morten.ofstad/NoSetErrorForJobBeforeDone into master
Merged Morten Ofstad requested to merge feature/morten.ofstad/NoSetErrorForJobBeforeDone into master
  1. Aug 25, 2023
    • Morten Ofstad's avatar
      The code in VolumeDataRequestProcessor::WaitForCompletion would call... · a34d2519
      Morten Ofstad authored 
      The code in VolumeDataRequestProcessor::WaitForCompletion would call SetErrorForJob also in the case where it reached the timeout and the job wasn't actually done, and this could lead to at deadlock. It's actually not necessary to set the error here at all, it will also be set in IsCanceled when you try to get the error.
      a34d2519