Skip to content

Introduce rafs app logic to client class

Arturo Hernandez [EPAM] requested to merge issue-156/fix-legal-property into main

Type of change

  • [NA] Bug Fix
  • [NA] Feature
  • Improvement

Does this introduce a change in the core logic?

  • [No]

Does this introduce a change in the cloud provider implementation, and if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a change that must be documented in the README.md file?

  • [No]

Updates description?

Describe your code changes in detail for reviewers (links on Gitlab issues, etc.

Integration tests and client classes were using flags and hardcoded BASE_URI, which breaks the local testing (core services installed in different BASE_URI).

This MR suggest mostly adopt the RAFS code style, such as:

  • re-use the .env.example values which are described, and add 2 more services (storage and legal), instead of re-using the BASE_URL.
  • Have a centralized settings file as core app/ rafs ddms code does, where all the settings should be described.
  • Usage of the pydantic baseSettings as core app does.

Related to !73 (merged)

Edited by Arturo Hernandez [EPAM]

Merge request reports