Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O Open ETP Server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Domain Data Management Services
  • Reservoir
  • Open ETP Server
  • Merge requests
  • !89

Update 'MiniZip' library to latest version and use it from VCPKG

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pavel Kisliak requested to merge epam/remove_internal_zlib into main Jan 10, 2023
  • Overview 2
  • Commits 2
  • Pipelines 8
  • Changes 15

Type of change

  • Bug Fix
  • Feature

Does this introduce a change in the core logic?

  • [No]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Updates description

  • Update MiniZip to latest version
  • Get new version of MiniZip from VCPKG manager (removed old version from project sources)
  • Fix all API incompatibilities
  • Use public library API for support Unicode path to files on Windows platform (previously there was modifications in the MiniZip sources)
  • Refactor caching of ZIP entities, use public API instead copying internal MiniZip data structure (this was lead to periodic crash 'corrupted size vs. prev_size' on latest version). There is no changes in performance (at least if trust execution time of test 'run_test_eml').
  • Removed define CACHE_FILE_DESCRIPTOR (I think that it's not make sense to turn it off since caching now uses public API)
Edited Jan 10, 2023 by Pavel Kisliak
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: epam/remove_internal_zlib