Skip to content

Issue #326 Upgrade azurerm and fix appinsights warnings

Arturo Hernandez [EPAM] requested to merge 326_azurerm_appinsights into master

All Submissions:

  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [YES] My code follows the code style of this project.

Current Behavior or Linked Issues

  • Upgrade AzureRM to upgrade on-fly app insights
  • Parametrize app insights
  • Refactor log -> enabled_log based on azurerm docs
  • Remove diag retention-days which it is managed by log-workspace - deprecated parameter
  • Refactor module code to avoid terraform warnings about deprecations
  • AKS Module refactor to avoid tf warnings (No replacement) - Remove deprecated parameters
  • AzureAd modules based refactor - remove deprecations
  • Fix Keyvault default policies for keys
  • Fix go unit test to not shown full output

Does this introduce a breaking change?

  • [NO]

We only noticed that AzureRM/AzureAD upgrade will probably only replace redis id, which will force to change the scope in the role assignment for Redis, nevertheless, it will take less than 30s and will not cause any downtime on application side (only needed when initialization happens and using probably azure authentication for redis - which it is not the use case). Current implementation relies on redis connection string.

Other information

Merge request reports