Removing AGIC components/fill docs
All Submissions:
- [YES] Have you added an explanation of what your changes do and why you'd like us to include them? Additionally added warnings
- [YES] I have updated the documentation accordingly.
- [YES] My code follows the code style of this project.
Current Behavior or Linked Issues
- Current implementation uses AGIC, we started in release/0.17 to migrate to only support appgw+istiogw and replace agic and agic-app-gw.
Does this introduce a breaking change?
- [YES]
Customer needs to change the AAA or ALIAS record to point to the new istio-appgw endpoint.
Other information
- TFPlan in bronwfield environments: tfplansr.log
- Execution in azure devops for dev environment (Green/Successful)
- Included fixes for #251 (closed)
Related issues/MR's:
- #236 (closed)
- #251 (closed)
- helm-charts-azure#19 (closed)
- Previous discussion in: !704 (closed)
WARN: For secret deletion there is a known error, which can be easily solved by second terraform plan/apply
.
module.appgateway.azurerm_public_ip.main: Destruction complete after 20s
azurerm_key_vault_certificate.default[0]: Destroying... [id=https://osdu-mvp-cr**-***-kv.vault.azure.net/certificates/appgw-ssl-cert/******]
azurerm_key_vault_certificate.default[0]: Still destroying... [id=https://osdu-mvp-cr**-***-kv.vault.az...-cert/******, 10s elapsed]
╷
│ Error: purging of Certificate "appgw-ssl-cert" (Key Vault "https://osdu-mvp-crdev-vq1b-kv.vault.azure.net/") : keyvault.BaseClient#PurgeDeletedCertificate: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="Operation \"purge\" is not allowed because purge protection is enabled for this vault. Key Vault service will automatically purge it after the retention period has passed.\r\nVault: osdu-mvp-crdev-vq1b-kv;location=centralus"
│
│
╵
Edited by Arturo Hernandez [EPAM]