Skip to content

Fixing sa secret issue and subscriptions warns

Arturo Hernandez [EPAM] requested to merge 248-ah/fix-dp-resources into master

All Submissions:

  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES] I have updated the documentation accordingly.
  • [YES] My code follows the code style of this project.

Current Behavior or Linked Issues

Review bug/issue #248 (closed) for further details, introduced in !744 (merged).

Does this introduce a breaking change?

  • [NO]

Introduces fixes for Storage account missing property and secret setup, also it fixes the unit-test for dp resources.

Other information

Expected plan output on brownfield deployments:

azurerm_storage_account_customer_managed_key.storage["storage_sdms"]: Refreshing state... [id=/subscriptions/ac3b3831-2ff7-4d4c-85d8-ef479ab45dbf/resourceGroups/osdu-mvp-dp1epmosdu-z48i-rg/providers/Microsoft.Storage/storageAccounts/osdumvpdp1epmoz48isdms]
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:
  
  # azurerm_key_vault_secret.storage_account_blob_endpoint will be created
  + resource "azurerm_key_vault_secret" "storage_account_blob_endpoint" {
      + id             = (known after apply)
      + key_vault_id   = "/subscriptions/xxxxx/resourceGroups/osdu-mvp-cr****sdu-dwk9-rg/providers/Microsoft.KeyVault/vaults/osdumvpcr****sdwk9kv"
      + name           = "opendes-storage-account-blob-endpoint"
      + value          = (sensitive value)
      + version        = (known after apply)
      + versionless_id = (known after apply)
    }
  
  # module.service_bus.azurerm_servicebus_topic.main[0] will be updated in-place
  ~ resource "azurerm_servicebus_topic" "main" {
      ~ auto_delete_on_idle                     = "P10675199DT2H48M5.4775807S" -> "P5D"
      ~ default_message_ttl                     = "P10675199DT2H48M5.4775807S" -> "PT12H"
        id                                      = "/subscriptions/*****************/resourceGroups/osdu-mvp-dp1****sdu-z48i-rg/providers/Microsoft.ServiceBus/namespaces/osdu-mvp-dp1****-z48i-bus/topics/indexing-progress"
        name                                    = "indexing-progress"
        # (12 unchanged attributes hidden)
    }   
===< SKIP OUTPUT >=======
  
  # module.service_bus.azurerm_servicebus_topic.main[6] will be updated in-place
  ~ resource "azurerm_servicebus_topic" "main" {
      ~ auto_delete_on_idle                     = "P10675199DT2H48M5.4775807S" -> "P5D"
      ~ default_message_ttl                     = "P10675199DT2H48M5.4775807S" -> "PT12H"
        id                                      = "/subscriptions/*****************/resourceGroups/osdu-mvp-dp1****sdu-z48i-rg/providers/Microsoft.ServiceBus/namespaces/osdu-mvp-dp1****-z48i-bus/topics/schemachangedtopiceg"
        name                                    = "schemachangedtopiceg"
        # (12 unchanged attributes hidden)
    }

And will get rid of service bus warnings:

╷
│ Warning: Argument is deprecated
│
│   with module.service_bus.azurerm_servicebus_namespace_authorization_rule.main,
│   on ../../../modules/providers/azure/service-bus/main.tf line 144, in resource "azurerm_servicebus_namespace_authorization_rule" "main":
│  144:   namespace_name      = azurerm_servicebus_namespace.main.name
│
│ Deprecated in favor of "namespace_id"
│
│ (and 18 more similar warnings elsewhere)
╵

Closes #248 (closed)

Merge request reports