Skip to content

Adding missing tfenvs for eds and reservoir ddms in infraplan

Arturo Hernandez [EPAM] requested to merge ah/add-azdevops-planvars into master

All Submissions:

  • [YES] Have you added an explanation of what your changes do and why you'd like us to include them? Already Added
  • [YES] I have updated the documentation accordingly, already documented
  • [YES] My code follows the code style of this project, Added new envs for infra azure devops

Current Behavior or Linked Issues

  • Infra tf plan will not take the variables that are required to optionally install the reservoir or kv features needed for the eds and reservoir ddms's.

Seems like env vars are not get directly from library variables, but need to be harcoded in the tf-plan.tf file

  • Buggy deletion of reservoir resources when disabling flag fixed by introducing reservoir module instead.

Current Behavior (After enabling and then disabling reservoir flag):

azurerm_storage_account_customer_managed_key.storage["storage_sdms"]: Refreshing state... [id=/subscriptions/ac3b3831-2ff7-4d4c-85d8-ef479ab45dbf/resourceGroups/osdu-mvp-dp3epmosdu-u2sr-rg/providers/Microsoft.Storage/storageAccounts/osdumvpdp3epmou2srsdms]

Warning: Argument is deprecated

  on ../../../modules/providers/azure/service-bus/main.tf line 144, in resource "azurerm_servicebus_namespace_authorization_rule" "main":
 144:   namespace_name      = azurerm_servicebus_namespace.main.name

Deprecated in favor of "namespace_id"

(and 18 more similar warnings elsewhere)


Error: Invalid index

  on reservoir-ddms-resources.tf line 22, in locals:
  22:   reservoir_postgres_password = random_password.postgres_reservoir[0].result
    |----------------
    | random_password.postgres_reservoir is empty tuple

The given key does not identify an element in this collection value.

Module creation instead for the reservoir resources, using airflow optional feature per partition approach.

Does this introduce a breaking change?

  • [NO] Introduce fix for buggy terraform feature

Other information

Related to: !666 (merged) #230 (closed) osdu/platform/domain-data-mgmt-services/reservoir/open-etp-server#3 (closed)

Edited by Arturo Hernandez [EPAM]

Merge request reports