Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • S Stream Admin Service
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe Software
  • Platform
  • Data Flow
  • Real Time
  • Streams
  • Stream Admin Service
  • Merge requests
  • !12

testing in AWS environment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dmitry Kniazev requested to merge demo/aws into develop Nov 09, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 8

I have made a few changes to the TopicAdminService and its interface to make it work because the idea was to derive the topic names from the stream record/stream definition attributes: SourceBindings | SinkBindings or both (depending on the stream type). I have also implemented this logic in the StreamAdminService simply because I didn't want to touch the TopicAdminService.

This MR is for review only, we don't have to actually merge it.

Other things to discuss:

  • How to provide the ENV variables in the stream record?
  • Further integration testing with the Fake ETP Producer? Deployment definition?
  • Remove the ECR registry name from the stream record -> move it to the StreamAdminService configuration
  • Handling Exceptions -> propagate them to the Controller? What's the best practice?

Will discuss more in our meeting tomorrow at 10am Central Time.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: demo/aws