Fixed get workflow status request by workflowName (GONRG-3007)
Type of change
-
Bug Fix -
Feature
issue: #129 (closed)
Does this introduce a change in the core logic?
- [YES]
Does this introduce a change in the cloud provider implementation, if so which cloud?
-
AWS -
Azure -
GCP -
IBM
Does this introduce a breaking change?
- [YES]
What is the current behavior?
GET "/{workflow_name}/workflowRun/{runId}" request used 'dagName' instead of 'workflowName' underhood during airflow call. In case of different 'dagName' and 'workflowName' it leads error:
{
"code": 404,
"reason": "Failed to send request.",
"message": "Unable to send request to Airflow. 404 NOT FOUND_{\"error\":\"Dag id workflow_name not found in DagModel\"}_"
}
So, 'dagName' parameter was replaced with 'workflowName' in airflow request in workflow-core/src/main/java/org/opengroup/osdu/workflow/service/AirflowWorkflowEngineServiceImpl.java
According to the airflow docs there should be dagName https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/get_dag_run or https://airflow.apache.org/docs/apache-airflow/stable/deprecated-rest-api-ref.html
Edited by Riabokon Stanislav(EPAM)[GCP]