Skip to content
GitLab

Adding system dags support in core

Merged Aalekh Jain requested to merge SystemDags-Core into master

Link to the ADR: #118

Changes required for AWS, GCP and IBM

The following SPIs needs to be implemented for AWS, GCP and IBM -

  1. IWorkflowSystemMetadataRepository (Link to azure implementation for reference: here)

  2. IAdminAuthorizationService (Link to azure implementation for reference: here)

Once these SPIs are implemented, the ITs for the corresponding can be extended for each of the cloud provider by extending the base abstract class which is - DeleteSystemWorkflowV3IntegrationTests and PostCreateSystemWorkflowV3IntegrationTests. For reference, this is how it's done for azure.

  1. Extending ITs for delete system workflow - https://community.opengroup.org/osdu/platform/data-flow/ingestion/ingestion-workflow/-/blob/bc469fb101f27c24670bf03bc92760ad7303d747/testing/workflow-test-azure/src/test/java/org/opengroup/osdu/azure/workflow/workflow/TestDeleteSystemWorkflowV3Integration.java

  2. Extending ITs for create system workflow - https://community.opengroup.org/osdu/platform/data-flow/ingestion/ingestion-workflow/-/blob/bc469fb101f27c24670bf03bc92760ad7303d747/testing/workflow-test-azure/src/test/java/org/opengroup/osdu/azure/workflow/workflow/TestPostCreateSystemWorkflowV3Integration.java

The expected behaviour of system workflows is presented in the ADR.

Edited by Aalekh Jain

Merge request reports