Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • I Ingestion Workflow
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Data Flow
  • Data IngestionData Ingestion
  • Ingestion Workflow
  • Merge requests
  • !146

Adding system dags support in core

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aalekh Jain requested to merge SystemDags-Core into master Aug 13, 2021
  • Overview 83
  • Commits 49
  • Pipelines 69
  • Changes 46

Link to the ADR: #118

Changes required for AWS, GCP and IBM

The following SPIs needs to be implemented for AWS, GCP and IBM -

  1. IWorkflowSystemMetadataRepository (Link to azure implementation for reference: here)

  2. IAdminAuthorizationService (Link to azure implementation for reference: here)

Once these SPIs are implemented, the ITs for the corresponding can be extended for each of the cloud provider by extending the base abstract class which is - DeleteSystemWorkflowV3IntegrationTests and PostCreateSystemWorkflowV3IntegrationTests. For reference, this is how it's done for azure.

  1. Extending ITs for delete system workflow - https://community.opengroup.org/osdu/platform/data-flow/ingestion/ingestion-workflow/-/blob/bc469fb101f27c24670bf03bc92760ad7303d747/testing/workflow-test-azure/src/test/java/org/opengroup/osdu/azure/workflow/workflow/TestDeleteSystemWorkflowV3Integration.java

  2. Extending ITs for create system workflow - https://community.opengroup.org/osdu/platform/data-flow/ingestion/ingestion-workflow/-/blob/bc469fb101f27c24670bf03bc92760ad7303d747/testing/workflow-test-azure/src/test/java/org/opengroup/osdu/azure/workflow/workflow/TestPostCreateSystemWorkflowV3Integration.java

The expected behaviour of system workflows is presented in the ADR.

Edited Sep 23, 2021 by Aalekh Jain
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: SystemDags-Core