Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • W wks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Upcoming Change to GitLab Pages The GitLab Pages URL is planned to migrate from the current *.pages.community.opengroup.org to a simpler domain: *.pages.opengroup.org. At the same time, HTTPS will be enabled for the server. This change is planned for May 21, 2022.

If you have questions or concerns, please email forum-support@opengroup.org.

  • Open Subsurface Data Universe Software
  • Platform
  • Data Flow
  • Data Enrichment
  • wks
  • Merge requests
  • !5

Merged
Created Sep 01, 2020 by Aman Verma@amavermaDeveloper

consuming new methods defined in BlobStore class

  • Overview 4
  • Commits 2
  • Pipelines 4
  • Changes 3

All Submissions:


  • [YES/NO] I have added an explanation of what changes in this merge do and why we should include it? YES
  • [YES/NO] I have updated the documentation accordingly. YES
  • [YES/NO/NA] I have added tests to cover my changes. YES
  • [YES/NO/NA] All new and existing tests passed. YES
  • [YES/NO/NA] My code follows the code style of this project. YES

What is the issue or story related to the change?


High level design: The BlobStore class container two types of methods for interacting with blob storage. One where we can supply the container name as parameter and other where it is not needed. Going forward, the second types of methods are being deprecated, hence updating all the blob storage related method calls to first type.

Issue: Related MR: osdu/platform/system/schema-service!21 (merged)

Change details:

  1. Calling *FromStorageContainer methods instead of *FromBlob methods
  2. Updated UTs.

Test coverage:


All integration tests passing locally.

Does this introduce a breaking change?


  • [YES/NO] NO

Pending items


Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information


FYI @kibattul , @polavishnu ,@danielscholl , @dkodeih , @harshit283

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: users/amaverma/moveToLatesCoreLib