Skip to content

Fix AST Parser

Levi Remington requested to merge fix-ast-parser-bug-lr into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)
#472 (closed)

Does this introduce a change in the core logic?

  • [YES/NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [YES/NO]

What is the current behavior?

AST Parser is passed the entire, unfiltered query, which includes all columns between "SELECT" and "FROM".

What is the new/expected behavior?

AST Parser is passed a truncated query, capturing the entire unaltered where clause, but replacing the columns with "*". This modified query is only used for the AST Parser, whose end result is indifferent to the columns. It is strictly to eliminate chance of a reserved word (like "KEY") from appearing in the Fields list. This does not affect queries processed by GCZ/Ignite.

Have you added/updated Unit Tests and Integration Tests?

NA

Any other useful information

Merge request reports