Skip to content

Added configmaps for Azure provider and transformer deployments

Deepanshu Singhal requested to merge az/ds-add-configmaps into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • NO

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • NO

What is the current behavior?

  • Currently, configuration files application.yaml and koop-config.yaml are added to the Dockerfile at the time of image build and are therefore tightly coupled which makes it difficutl to make any config changes at runtime.

What is the new/expected behavior?

  • Configmaps have been added to the helm charts of provider and transformer Azure provider layer. These configmaps are mounted to the pods as volumes which can be easily modified without making changes to the image. The changes done to configmap are usually synced with the pod in 1-2 minutes.
  • Following command can be used to update/edit the configmap file contents for testing purposes -
    kubectl edit configmap <configmap_name> -n <namespace>  
    This opens a text editor in which the changes can be made. Once the file is saved and closed, the changes are applied to the existing configmap and then synced with the pod.

Have you added/updated Unit Tests and Integration Tests?

  • Not required

Any other useful information

  • application.yaml for Azure transformer will be mounted to config ("/config") directory now instead of root ("/"). The location to fetch this file at runtime has been updated in the Dockerfile parameter.
  • Moved both config files to the Azure charts directory so that they can be fetched directly by the configmap from there.
Edited by Deepanshu Singhal

Merge request reports

Loading