Skip to content

Additional fix to concrete core Auth class beeing used instead of CSP specific one

Guillaume Caillet requested to merge aws-fix-csp-specific into master

Type of change

  • Bug Fix
  • Feature

This is a follow-up to the previous MR !128 (merged) which was incomplete. In some places, the concrete, base 1Authenticate1 class was used, not the CSP provided one.

This remove a few unused methods, replace in some function signature the requirements of the concrete Authenticate class by the IAuthenticate interface (thus allowing a CSP-specific implementation to be used) and transform the current base Authenticate class into a Spring component, so it can be injected like a CSP-specific one (so the Transformer is able to load properly even if no CSP-provider module is loaded)

Does this introduce a change in the core logic?

  • [YES]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

What is the new/expected behavior?

Have you added/updated Unit Tests and Integration Tests?

Any other useful information

Merge request reports