Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • P Platform Validation
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Platform Validation
  • Merge requests
  • !96

Fix secret protection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Diederich requested to merge fix-secret-protection into master Jul 31, 2020
  • Overview 3
  • Commits 5
  • Pipelines 1
  • Changes 2

This does two things.

First, and most importantly, I added a second "test -f" check so that the pipeline actually fails. I don't know why my too-clever-by-half solution of "test || (echo && false)" didn't work, but this simpler way seems to work better.

Second, I put a ton more information in the error message. I also moved it to a text file, so that I didn't have to escape every little shell character in my message. Hopefully this helps remove some confusion about how to address these problems.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-secret-protection