Skip to content

Adding CustomThreadPoolFactory

Vibhuti Sharma [Microsoft] requested to merge users/Vibhuti/MDC-Aware-Concurrency into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [NO] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

High level design: Adding CustomThreadPoolFactory to enable creation of CustomThreadPoolExecutor from core-lib-azure, which allows for copying of context from main thread to child threads.

Issue: Concurrency classes being used from the java.util.concurrency package do not allow copying of MDC and request context from main thread to child threads.

Change details:

Test coverage:

Does this introduce a breaking change?

  • NO

Pending items

This MR should only be merged after this one - osdu/platform/system/lib/cloud/azure/os-core-lib-azure!69 (diffs)

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Edited by Vibhuti Sharma [Microsoft]

Merge request reports