Revert "[MS-44412] Remove unused GCS Array Validation"

Yurii Kondakovrequested to merge
add-gcs-version-paths-limit into master

Issue - #338

Globally, this MR returns a feature that was removed in the past, limiting the number of record versions. When creating or update record operation, it checks whether the number of record versions exceeds the maximum limit (2000 by default), and if so, the record is not created (updated). A message explaining why this happened is placed in the new errors field.

With this MR the following changes are made:

  1. "Remove unused GCS Array Validation" MR !923 (merged) is reverted
  2. To correct the problems that existed in the previous implementation (issue - #254), a new errors field for the CreateUpdateRecordsResponse has been added.

The changes are being implemented under the feature flag. No additional actions are required if this feature is not needed.

If a new feature flag is not enabled, the JSON output will be identical and HTTP status code will be the same(201). If a FF is enabled response status code will also be 201 and errors array will be non empty when number of versions exceeds the limit.

The feature name: limiting-number-of-record-versions-enabled

Response example with the new errors field

image.png

Os-core-common MR for adding new errors field osdu/platform/system/lib/core/os-core-common!311 (merged).

Edited by Yurii Kondakov

Merge request reports