Skip to content

WIP: minimal set of changes to remove segfault in GCE / GCS (direct or via SD )...

Anthony Lichnewsky requested to merge slb/al/fix-auth-lack-of-bearer-scheme-on-authorization-headers-and-segfault-everywhere-on-gce into master

minimal set of changes to remove segfault in GCE / GCS (direct or via SD ) segfaults, missing Bearer scheme on service calls Authorization headers

direct usage of seismicstore::GcsAccessor ( for example in functionality / regression tests ) on GCE was segfaulting straight away.

usage of GcsAccessor via SDGenericDataset on GCE failed with failures to parse JWT, because API calls are Authorized with the token credentials without the "Bearer" scheme.

For some reason, MRs are accepted without testing on GCE and we managed to distribute libsdapi.so without running regression test. Zenith is broken for now. Omega did not pick it up...

I still need to verify that the change does not break authz on other platforms.

I called this MR "minimal". I'd like to have API changes in the lib/auth directory. these are not meant to be public symbols. But on linux, since they are all in the seismicdrive namespace, they are actually part of the ABI ...

  • getAuthToken() -> getAuthorizationHeader()

Merge request reports