SEG-Y sdpath is read from the FileCollectionPath attribute instead of combining with FileSource

Data definition

Here are the definitions of FileCollectionPath and FileSource from FileCollection.SEGY Data Properties

Cumulative Name	Description
data.DatasetProperties.FileCollectionPath	The mandatory path to the file collection. A FileCollectionPath should represent folder level access to a set of files.
data.DatasetProperties.FileSourceInfos[].FileSource	The location of the file. It can be a relative path. The actual access is provided via the File Service. When used in context of a FileCollection (dataset--FileCollection*) FileSource is a relative path from the FileCollectionPath. It can be used by consumers to pull an individual file if they so choose by concatenating the FileCollectionPath with the FileSource. This property is required.

Implementation

The DAG is currently reading the FileCollectionPath only, assuming that it is the full sd:// path to the SEG-Y file in Seismic DDMS.
The two interesting lines of code are in segy_open_vds_conversion and base_metadata.py

Suggested fix

• Read FileCollection.SEGY
  • if the FileSourceInfos array has FileSource that is relative (startswith("./")) then concatenate with FileCollectionPath
  • if the FileSourceInfos array has FileSource that is a full path (startswith("sd://") then use it.
  • fallback on current behavior (use FileCollectionPath)
• Write FileCollection.Bluware.OpenVDS
  • Modify the created record to add data.DatasetProperties.FileSourceInfos[].FileSource