test(tests): increase test coverage to 99%

Daniel Scholl (MS]requested to merge
tests into main

Concise summary of changes

  • Introduced a comprehensive test suite to significantly boost test coverage for the osdu_activity project.
  • Added a new documentation spec for increasing test coverage.
  • Updated the test configuration to enforce a higher coverage threshold (80%).
  • Added extensive GitLab activity tests across multiple modules (fetcher, update, job_detector, models, and related integration scenarios).
  • Expanded test fixtures with a broad set of mock objects for GitLab API components.
  • Added new test files (notably tests/test_fetcher.py) and expanded tests/test_update.py, tests/test_job_detector.py, and tests/test_models.py to cover edge cases and advanced scenarios.

Key modifications and their purpose

  • docs/chore-increase-test-coverage.md (new): Provides a detailed plan and acceptance criteria for raising test coverage to the 80-85% range, with a focus on gitlab/fetcher.py and other modules.
  • pyproject.toml (coverage threshold updated): Set cov-fail-under from 60% to 80% to enforce higher baseline test coverage in CI.
  • tests/conftest.py (new fixtures): Added a comprehensive set of GitLab API mock fixtures (mock_gitlab_client, mock_gitlab_project, mock_gitlab_merge_request, mock_gitlab_pipeline, mock_gitlab_job, mock_gitlab_issue, mock_merged_mr) to support extensive, isolated unit tests of the fetcher.
  • tests/test_fetcher.py (new): Large suite validating ActivityFetcher behavior, including initialization, parallel project fetching, MR fetching, downstream pipeline discovery, job fetching, issue fetching, author/assignee handling, and robust exception paths.
    • Tests for:
      • Initialization and worker limits
      • fetch_project_activity with and without MRs/issues
      • fetch_projects_parallel with progress callbacks and error aggregation
      • _fetch_last_merge_date, _fetch_merge_requests, _fetch_mr_pipelines
      • _find_downstream_pipeline, _fetch_pipeline_jobs, _fetch_downstream_jobs
      • _fetch_issues with provider filtering, deduplication, and edge cases
      • Advanced scenarios including downstream pipelines and edge-case job handling
      • Full integration-like test path combining MR, pipelines, jobs, and issues
  • tests/test_job_detector.py (updated): Added tests for is_core_provider_job, get_test_type, and is_test_job edge cases to improve coverage on detection logic.
  • tests/test_models.py (updated): Added tests for edge cases in ActivitySummary.create(), including running pipelines, provider labeling/counting, and issue/pipeline status aggregation.
  • tests/test_update.py (updated): Added tests for fetch_latest_version, fetch_releases, display_changelog, plus related error paths and author/assignee handling in issues.
  • Security impact analysis: No vulnerability data is provided in this diff. All changes are test scaffolding and coverage improvements using mocked GitLab API objects. There are no code changes intended to fix or introduce security vulnerabilities, and no vulnerability findings are discussed or modified. The changes affect the testing surface and CI enforcement rather than runtime security controls.

Notable technical details

  • Extensive use of unittest.mock.MagicMock and pytest fixtures to simulate GitLab API objects (projects, merge requests, pipelines, jobs, issues) and their interactions.
  • Coverage-focused testing strategy includes:
    • Handling of missing projects, API exceptions, and edge cases (e.g., draft MRs, author formats, assignee formats).
    • Parallel and sequential execution paths for project fetches.
    • Detailed MR/pipeline/job/issue processing workflows, including downstream/upstream relationships.
    • Deduplication logic for issues and robust provider filter handling.
  • Tests aim to validate both happy-path scenarios and resilient failure paths, providing a broad baseline for regression testing of ActivityFetcher and related components.
  • Acceptance criteria alignment: Coverage thresholds increased to 80% and a wide range of modules (fetcher, update, job_detector, models) covered with high-fidelity tests.

Last change class TestUpgradePackage: """Tests for upgrade_package function."""

Merge request reports