Workflow used:
Timeout:
Referring to below SS, at ~30rps, max time taken to respond was approx 1 minute. On the basis of discussion with SO and their previous experience it has been finalised as 180 secs.
Circuit Breaker:
Ejection timeout(Time taken by REgister pod to restart itself from failure ~2 mins) :
Rate limit:
Number of requests that does not lead to 503s.
p.s. Check infra related changes and prior discussions here : !247 For retries here : !245
Please provide link to gitlab issue or ADR(Architecture Decision Record)
Please provide link to gitlab issue or ADR(Architecture Decision Record)
Extend the AbstractMessageHandler class form core-lib-azure to utilize common worker logs.
Please provide link to gitlab issue or ADR(Architecture Decision Record)
osdu/platform/data-flow/ingestion/home#51
Doesn't change any functionalities. Only increases code coverage.
Code coverage was not tracked for core modules. Coverage was a low 13%.
Increased coverage to 80%.
a few existing tests were modified. New classes are covered. Only unit tests impacted.
Can we also check if necessary headers are added in the response?
There should be a test associated with put
.
assertNotNull(dpsHeaders); ?
Hi @spellikoduku , please provide a reason why this throw statement is being removed.
Hi @spellikoduku , please explain the need of this if else block? What use case does it solve? Why number 8 has been hard coded here?
@spellikoduku , why is the exception being suppressed?
Sathyanarayanan Saravanamuthu (a5d3fdf7) at 29 Mar 13:27
Merge branch 'smanjunath/increaseCodeCoverage' into 'master'
... and 31 more commits
This is just a utility or helper function. Not sure why this has been carved out as a class.
We can call getHeaders
and validate if the new values are getting reflected as exptected.