Storage merge requestshttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests2021-02-05T00:45:06Zhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/69Leveraging AzureServicePrinciple class to utilize from core lib azure2021-02-05T00:45:06Zsatish kumar narganiLeveraging AzureServicePrinciple class to utilize from core lib azure# Merge request template# Merge request templateChristian LecknerDania Kodeih (Microsoft)Nandu MuralidharanChristian Lecknerhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/70Upgrading core-lib-azure version2021-02-03T10:06:18ZAbhishek PatilUpgrading core-lib-azure version- Upgrading the version of dependency `core-lib-azure` to latest 0.0.29.
- Removed TenantFactoryImpl class and using the same from core-lib-azure.- Upgrading the version of dependency `core-lib-azure` to latest 0.0.29.
- Removed TenantFactoryImpl class and using the same from core-lib-azure.Abhishek PatilAbhishek Patilhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/71new cosmosstore method2020-09-26T09:04:46ZChristian Lecknernew cosmosstore method# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/75WIP: trying out $MAVEN instead of mvn2020-09-30T21:27:10ZNicholas KarskyWIP: trying out $MAVEN instead of mvntesting out using $MAVEN instead of mvn because some r3 services need $MAVENtesting out using $MAVEN instead of mvn because some r3 services need $MAVENNicholas KarskyNicholas Karskyhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/83WIP: Mongodb integration2020-11-23T04:42:43ZAleh Shubko [EPAM]WIP: Mongodb integrationAdd MongoDB integrationAdd MongoDB integrationAleh Shubko [EPAM]Aleh Shubko [EPAM]https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/85Added Mockito Test Cases for repository in storage-azure2021-02-05T00:45:21Zsatish kumar narganiAdded Mockito Test Cases for repository in storage-azure# Merge request template# Merge request templateChristian LecknerDania Kodeih (Microsoft)Christian Lecknerhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/87adds redis cache for azure provider2021-11-19T11:58:19ZAliaksei Darafeyeuadds redis cache for azure provider## Type of change
- [X] Feature
## Does this introduce a change in the core logic?
- [YES]
## small refactoring: adds interface in core for existing cache GroupCache, LegalTagCache, SchemaCache.
- [X] AWS
- [X] Azure
- [X] GCP
- [X] IBM...## Type of change
- [X] Feature
## Does this introduce a change in the core logic?
- [YES]
## small refactoring: adds interface in core for existing cache GroupCache, LegalTagCache, SchemaCache.
- [X] AWS
- [X] Azure
- [X] GCP
- [X] IBM
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [X] Azure
## Does this introduce a breaking change?
- [NO]
## What is the new/expected behavior?
adds ability use redis or inMemory for azure providerNitin-slbDaniel SchollSherman YangPavel BachylaAlok JoshiDuvelis CaraoNitin-slbhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/88Draft: Added logic to fail application for multiple slf4j bindings2020-10-30T13:05:58ZVibhuti Sharma [Microsoft]Draft: Added logic to fail application for multiple slf4j bindings## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NA] I have updated the documentation accordingly.
* [NA] I have added tests t...## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NA] I have updated the documentation accordingly.
* [NA] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [NA] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
High level design:
Added logic to start the application only if there are no multiple bindings for slf4j
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
If there are multiple bindings available for slf4j, then the binding with log4j2 breaks and consequently the integration with appinsights also breaks. Till date only a warning was being thrown in this scenario, and the application would run without logs going to appinsights. There is a need to fail the application if appinsights integration is broken in such a way.
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
NA
## Does this introduce a breaking change?
-------------------------------------
- NO
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
NA
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->Vibhuti Sharma [Microsoft]Vibhuti Sharma [Microsoft]https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/92increase services instances to 22020-11-09T21:30:54ZAlok Joshiincrease services instances to 2# Merge request template
Increase Azure services instances to 2# Merge request template
Increase Azure services instances to 2Dania Kodeih (Microsoft)Neelesh ThakurDaniel SchollImran SiddiqueDania Kodeih (Microsoft)https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/94Draft: Temporary use custom pipe2020-11-11T13:28:55ZAliaksandr Ramanovich (EPAM)Draft: Temporary use custom pipe# Merge request template
Temp request. It won't be merged# Merge request template
Temp request. It won't be mergedhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/96Osdu-gcp storage: Add var for default country2020-11-13T13:06:12ZOleksandr Kosse (EPAM)Osdu-gcp storage: Add var for default country# Merge request template# Merge request templateOleksandr Kosse (EPAM)Oleksandr Kosse (EPAM)https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/98Disabling keyVault health indicator2021-02-03T10:06:04ZAbhishek PatilDisabling keyVault health indicator## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provi...## Type of change
- [X] Bug Fix
- [ ] Feature
**Please provide link to gitlab issue or ADR(Architecture Decision Record)**
## Does this introduce a change in the core logic?
- [NO]
## Does this introduce a change in the cloud provider implementation, if so which cloud?
- [ ] AWS
- [X] Azure
- [ ] GCP
- [ ] IBM
## Does this introduce a breaking change?
- [NO]
## What is the current behavior?
/actuator/health endpoint returns 503 due to failure in azure-key-vault health indicator
## What is the new/expected behavior?
azure-key-vault health indicator is disabled which makes /actuator/health endpoint green
## Have you added/updated Unit Tests and Integration Tests?
NA
## Any other useful informationAbhishek PatilAbhishek Patilhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/102Draft: Mongodb integration2020-11-23T07:09:14ZAleh Shubko [EPAM]Draft: Mongodb integrationAleh Shubko [EPAM]Aleh Shubko [EPAM]https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/104add record tags CRUD api with integration tests;2021-01-25T18:26:51ZYauheni Lesnikauadd record tags CRUD api with integration tests;Add reord tags support and Tags CRUD apiAdd reord tags support and Tags CRUD apiethiraj krishnamanaiduNeelesh ThakurAlok JoshiHong YanYauheni Lesnikauethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/106Publishing to Event Grid and Service Bus2020-12-16T13:29:13ZKomal MakkarPublishing to Event Grid and Service Bus
## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have ...
## All Submissions:
-------------------------------------
* [YES] I have added an explanation of what changes in this merge do and why we should include it?
* [NO] Does the MR contain pipeline/ helm chart related changes?
* [NO] I have updated the documentation accordingly.
* [YES] I have added tests to cover my changes.
* [YES] All new and existing tests passed.
* [YES] My code follows the code style of this project.
* [YES] I ran lint checks locally prior to submission.
## What is the issue or story related to the change?
-------------------------------------
<!-- Please describe the current behavior that you are modifying, 'or' link to a relevant issue.
Feel free to add references to any design documents you might have shared with the team or any
related MR that you are building on top of. -->
The storage service is publishing to Service Bus. As with R3, the infra of choice is EG, this change entails publishing to EG and SB.
**This change is directed towards achieving Intermediate Flow**
High level design:
![image](/uploads/86e8e867a434ddba1c83e3bba3e0d5d5/image.png)
Issue: <!-- Link any __GitLab__ workitem(s) to this pull request. -->
<!-- Please add implementation details of current set of changes and how the code changes are
doing what they are expected to do. Are there any complex loops or designated code blocks that
should be elaborated? Is there some contextual knowledge that the reviewer should be aware of? -->
Change details:
## Test coverage:
------------------
<!-- Mention unit test coverage of changes. -->
## Does this introduce a breaking change?
-------------------------------------
- [YES/NO]
<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->
## Pending items
----------------
<!-- Are there changes that you'll introduce in upcoming MRs and hence did not add in this one? Next steps of your
feature can also be mentioned here. -->
1. Using EG facade to achieve the same.
2. Updating the Readme
## Reviewer request
-------------------
- Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
- Block the MR if you feel there is less testing or no details in the MR
- Please cover the following aspects in the MR
-- Coding design: _\<Reviewer1>_
-- Backward Compatibility: _\<Reviewer2>_
-- Feature Logic: _\<Logic design\>_
-- _\<Any other context mention here>_
OR
-- _\<Component 1>_: _\<Reviewer1>_
-- _\<CosmosDB>_: _\<Reviewer2>_
-- _\<ServiceBus>_ _\<Reviewer3>_
-- _\<Mention any other component and owner>_
## Other information
-------------------------------------
<!-- Any other information that is important to this MR such as screenshots of how the component looks before and after the change. -->Kishore BattulaKishore Battulahttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/113WIP: Azure Parallelizing Writes2021-01-20T03:27:32ZJasonWIP: Azure Parallelizing Writes# Merge request template# Merge request templatehttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/116Improve code coverage2021-11-19T11:58:30ZAalekh JainImprove code coverageImproving the code coverage of Storage Service. Adding UTs.Improving the code coverage of Storage Service. Adding UTs.https://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/117WIP: Fixing ADO pipeline to only build azure provider code2021-04-26T15:55:13ZJasonWIP: Fixing ADO pipeline to only build azure provider code# Merge request template
Currently azure pipeline is passing in the option "-P storage-azure" when building the provider code and "-P storage-core" when building the core code. The -P flag is meant to indicate what profile to activate. I...# Merge request template
Currently azure pipeline is passing in the option "-P storage-azure" when building the provider code and "-P storage-core" when building the core code. The -P flag is meant to indicate what profile to activate. Instead, we want to be using the -pl argument, which indicates which modules should be built.JasonJasonhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/125add label property to the message of the azure event grid message, for...2021-04-05T09:53:47ZYauheni Lesnikauadd label property to the message of the azure event grid message, for...The amendment adds the label property to the event grid message (Azure implementation of IMessageBus) for the further filtering messages into the Azure Service Bus Subscribtions.
Issue: https://community.opengroup.org/osdu/platform/syste...The amendment adds the label property to the event grid message (Azure implementation of IMessageBus) for the further filtering messages into the Azure Service Bus Subscribtions.
Issue: https://community.opengroup.org/osdu/platform/system/storage/-/issues/43ethiraj krishnamanaiduDania Kodeih (Microsoft)Nitin-slbNeelesh Thakurashley kelhamDuvelis CaraoYauheni Lesnikauethiraj krishnamanaiduhttps://community.opengroup.org/osdu/platform/system/storage/-/merge_requests/132CORS Fix2021-03-05T21:22:52ZSpencer Suttonsuttonsp@amazon.comCORS Fix# Merge request template# Merge request templateSpencer Suttonsuttonsp@amazon.comSpencer Suttonsuttonsp@amazon.com